pytorch / pytorch/rl

[BUG] csv logger can't take "/" in metric names

Open
#2,006 0 comments 0 reactions 1 assignee View on GitHub

@vmoens is already working on this.

Since Mar 9, 2024.

bug
Dominant language
Python
Stars
3.6k
Forks
484
Avg merge
1d 1h
Merged PRs (30d)
207

Description

Describe the bug

If the metric one is trying to log with the csv logger has / in its name, you will get a No such file or directory error.

To Reproduce

Run the sac example in examples/sac/sac.py. In config.yaml, set logger/backend to csv.

You will get an error at line 44 of torchrl/record/loggers/csv.py:

if filepath not in self.files:
    self.files[filepath] = open(filepath, "a")

Reason and Possible fixes

This is because the sac example logs train reward as "train/reward" where "train/" is taken by the logger as a path.

The csv logger can perhaps automatically set all / in metric names as "_" instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.