[BUG] BoundedTensorSpec zero() returns out of bounds tensor
Open
bug
- Dominant language
- Python
- Stars
- 3.6k
- Forks
- 487
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 207
Description
Describe the bug
Calling zero() on the BoundedTensorSpec will return a tensor that is out of bounds. Would it make sense to return the minimum instead? Or raise an error?
My use case is initializing a nonzero recurrent state using TensorDictPrimer.
To Reproduce
from torchrl.data import BoundedTensorSpec
BoundedTensorSpec(minimum=1, maximum=2, shape=(3,)).zero()
>>> tensor([0., 0., 0.])
Checklist
- I have checked that there is no similar issue in the repo (required)
- I have read the documentation (required)
- I have provided a minimal working example to reproduce the bug (required)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.