pytorch / pytorch/rl

[Feature Request] Remove `env.dtype` attribute

Open
#11 0 comments 0 reactions 1 assignee View on GitHub

@vmoens is already working on this.

Since Feb 10, 2022.

enhancement quality
Dominant language
Python
Stars
3.6k
Forks
484
Avg merge
1d 1h
Merged PRs (30d)
207

Description

Initially the plan was for an environment to have some dtype associated. This was supposed to support actions, obs and reward.
However it makes little sense when observations are multiple tensors. Also, an action could be a floating point number and the observation a uint8 tensor.
We should rely only on env.observation_spec.dtype (or action_spec) to infer dtype.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.