[Feature Request] pytest --error-for-skips for dependencies
Open
@vmoens is already working on this.
Since Apr 12, 2023.
enhancement
- Dominant language
- Python
- Stars
- 3.6k
- Forks
- 487
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 207
Description
Motivation
In https://github.com/pytorch/rl/pull/1041, we forced the tests not to be skipped in the CI for envpool.
This should be the rule for all tests under .circleci/unittest/linux_libs, where pytest should always be called with --error-for-skips. This way, we can make sure that dependencies are always tested.
The situation we want to avoid is the one in which a dependency fails to be installed, and the related tests are all skipped because the library cannot be found.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.