pytorch / pytorch/pytorch

DISABLED test_del_same_stream_no_sync_dealloc_cuda (__main__.TestStreamsCUDA)

Open
#195,553 1 comment 0 reactions 0 assignees View on GitHub
module: dynamo module: flaky-tests oncall: pt2 skipped triaged
Dominant language
Python
Stars
103k
Forks
29.5k
PR merge metrics
PR metrics pending

Description

Platforms: linux

This test was disabled because it is failing in CI. See [recent examples](https://hud.pytorch.org/flakytest?name=test_del_same_stream_no_sync_dealloc_cuda&suite=TestStreamsCUDA&limit=100) and the most recent trunk [workflow logs](https://github.com/pytorch/pytorch/runs/99720722031).

Over the past 6 hours, it has been determined flaky in 3 workflow(s) with 3 failures and 3 successes.

**Debugging instructions (after clicking on the recent samples link):**
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:
1. Click on the workflow logs linked above
2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
3. Grep for `test_del_same_stream_no_sync_dealloc_cuda`
4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.

Sample error message

```
Traceback (most recent call last):
File "/__w/pytorch/pytorch/test/dynamo/test_streams.py", line 2546, in test_del_same_stream_no_sync_dealloc
self.assertEqual(expected, actual)
File "/opt/python-3.10-venv/lib/python3.10/site-packages/torch/_dynamo/test_case.py", line 128, in assertEqual
return super().assertEqual(x, y, *args, **kwargs)
File "/opt/python-3.10-venv/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 4936, in assertEqual
raise error_metas.pop()[0].to_error( # type: ignore[index]
AssertionError: Tensor-likes are not close!

Mismatched elements: 4 / 4 (100.0%)
Greatest absolute difference: 1.0 at index (0, 0) (up to 1e-05 allowed)
Greatest relative difference: 0.5 at index (0, 0) (up to 1.3e-06 allowed)

To execute this test, run the following from the base repo dir:
python test/dynamo/test_streams.py TestStreamsCUDA.test_del_same_stream_no_sync_dealloc_cuda

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
```

Test file path: `dynamo/test_streams.py`

For all disabled tests (by GitHub issue), see https://hud.pytorch.org/disabled.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @jataylo @azahed98

Contributor guide

Open the contributing guide

Research direction

Start with test/dynamo/test_streams.py and run `python test/dynamo/test_streams.py TestStreamsCUDA.test_del_same_stream_no_sync_dealloc_cuda`. Then inspect the linked flaky-test samples and workflow logs, grepping for the test name and comparing its successful and failing runs. Done means the cause of the tensor mismatch is understood, the test is reliable again, and it can be re-enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.