pytorch / pytorch/pytorch

[MPS][Inductor] AdaptiveMaxPool{1,2}d produces incorrect results (numerical correctness)

Open
#169,738 1 comment 0 reactions 0 assignees View on GitHub
module: correctness (silent) module: mps oncall: pt2 triaged
Dominant language
Python
Stars
103k
Forks
29.5k
PR merge metrics
PR metrics pending

Description

### 🐛 Describe the bug

When using `torch.compile(backend="inductor")` on MPS devices, `F.adaptive_max_pool1d` and `F.adaptive_max_pool2d` produce incorrect results with significant numerical divergence (diff > 1.0) compared to Eager mode.

This behavior is observed in both **1D** and **2D** cases.

### Reproduce script
```python
import torch
import torch.nn.functional as F

def fn(x):
return F.adaptive_max_pool1d(x, output_size=3)

torch.manual_seed(0)
x = torch.randn(4, 10, 8, device="mps")

# def fn(x):
# return F.adaptive_max_pool2d(x, output_size=(3, 3))

# x = torch.randn(4, 10, 8, 8,device='mps')

eager_out = fn(x)

opt_fn = torch.compile(fn, backend="inductor")

try:
compiled_out = opt_fn(x)
diff = (eager_out - compiled_out).abs().max().item()
print(f"Max Difference: {diff}")

except Exception as e:
print(f"Crashed during execution: {e}")
```

output
```bash
Max Difference: 1.704391598701477
```

### What's more
I found
https://github.com/pytorch/pytorch/blob/d3944da7f71207ce254cdfd66ad04b4ffe9a2e96/test/inductor/test_torchinductor.py#L5030-L5065

### Versions

PyTorch version: 2.10.0.dev20251202
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 26.1 (arm64)
GCC version: Could not collect
Clang version: 17.0.0 (clang-1700.4.4.1)
CMake version: Could not collect
Libc version: N/A

Python version: 3.12.12 (main, Oct 28 2025, 11:52:25) [Clang 20.1.4 ] (64-bit runtime)
Python platform: macOS-26.1-arm64-arm-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Is XPU available: False
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Apple M4

Versions of relevant libraries:
[pip3] Could not collect
[conda] Could not collect

cc @kulinseth @malfet @DenisVieriu97 @jhavukainen @chauhang @penguinwu

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.