pytorch / pytorch/pytorch

CI: What is the purpose of `slow.yml`

Open
#165,577 1 comment 1 reaction 0 assignees View on GitHub
module: ci needs research triaged
Dominant language
Python
Stars
103k
Forks
29.5k
PR merge metrics
PR metrics pending

Description

### 🐛 Describe the bug

What is the purpose of `slow.yml` job, when we can shard more and probably can rely on TD to skip slow tests if they are not needed?

In the past `slow.yml` job was a way of keeping time to signal low, while running some tests post commit, but now that we have TD we probably can get rid of concept of slow test and just run them conditionally on TD's decision

At the very least, I think this job should be viable/strict blocking, as it just runs a subset of tests from pull request, that are decorated with `@slowTest` or take more than 90 sec to finish
### Versions

CI

cc @seemethere @pytorch/pytorch-dev-infra

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.