pytorch / pytorch/gloo

Parse /proc/net/route to find default route + outgoing iface

Open
#40 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
1.5k
Forks
368
Avg merge
19h 32m
Merged PRs (30d)
3

Description

Do this instead of assuming hostname(2) is resolvable. This is typically not the case on people's custom Ubuntu installs and whatnot. We keep the API the same but just change the default behavior.

See the default path in gloo::transport::tcp::CreateDevice (https://github.com/facebookincubator/gloo/blob/master/gloo/transport/tcp/device.cc#L36-L42).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the default-path code in gloo/transport/tcp/device.cc, especially lines 36–42, and inspect how CreateDevice currently relies on hostname(2). Determine how /proc/net/route represents the default route and outgoing interface. Done means the API remains unchanged while its default behavior derives the outgoing interface from that route instead of assuming hostname resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, linux
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.