Change unsigned long to unsigned long long in gloo/cuda_allreduce_ring_chunked.cc and gloo/allreduce_ring_chunked.h
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.5k
- Forks
- 368
- Avg merge
- 19h 32m
- Merged PRs (30d)
- 3
Description
Code review comment from Orvid in PR https://github.com/facebookincubator/gloo/pull/264
Just make this explicitly an unsigned long long. long is 64-bit on linux, but 32-bit on windows, so it's far better to make this explicit. (I would recommend searching through gloo for any references to bare long and fixing them, otherwise you're likely to run into issues later)
Issues:
Simply change unsigned long to unsigned long long will leads test code compile error. Need investigate and fix conflicts in test code introduced by this change.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with gloo/cuda_allreduce_ring_chunked.cc and gloo/allreduce_ring_chunked.h, then search the gloo sources for bare long references as suggested. Build and run the test code to identify compile conflicts caused by the type change; done means the affected code uses unsigned long long explicitly and the tests compile successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100