pytorch / pytorch/executorch

phi-3-mini is not a valid Python package name

Open
#5,509 4 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

module: examples triaged
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

🐛 Describe the bug

There is a minor issue with examples/models/phi-3-mini/ that prevents strict tools to analyse it: the folder name is phi-3-mini, and because it contains an __init__.py file this is a package. However, dashes are not valid in package names. Renaming the folder to phi_3_mini would resolve this issue.

Versions

Main branch

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.