pytorch / pytorch/executorch

GHSA-84m3-f99p-cqx5: claimed fixed version 0.7.0 still ships pre-fix code (fix not present until 1.1.0)

Open
#19,135 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module: runtime
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

Advisory Metadata Mismatch Report

Summary

GHSA-84m3-f99p-cqx5 claims executorch==0.7.0 is the fixed version. However, the released artifact on PyPI ships runtime/core/hierarchical_allocator.h and runtime/core/memory_allocator.h that are byte-identical to the pre-fix versions. The fix commit was never merged into any release tag through v1.0.1. The fix first appears in 1.1.0.

Details

Field Value
Package executorch
Registry PyPI
Claimed fixed version 0.7.0
Advisory https://github.com/advisories/GHSA-84m3-f99p-cqx5
Fix commit https://github.com/pytorch/executorch/commit/0830af820724
Commit is ancestor of tag No (v0.7.0 through v1.0.1)
Truly fixed version 1.1.0

Evidence

runtime/core/hierarchical_allocator.h and runtime/core/memory_allocator.h in the 0.7.0 artifact match the pre-fix state. The fix commit exists only on a cherry-pick branch; the equivalent fix on main landed in v1.1.0.

Recommendation

Update the advisory to correct the fixed version to 1.1.0.

cc @larryliu0820 @JacobSzwejbka @lucylq

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the GHSA-84m3-f99p-cqx5 advisory and comparing the listed release tags with runtime/core/hierarchical_allocator.h and runtime/core/memory_allocator.h. Verify the fix commit and the first release containing it, then update the advisory's fixed version to 1.1.0; done means the advisory metadata matches the released code.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.