ATOL and RTOL should probably be configurable per-test. Ideally, we also make the defaults as small as possible and override it on tests that need it.
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 581
Description
ATOL and RTOL should probably be configurable per-test. Ideally, we also make the defaults as small as possible and override it on tests that need it.
Originally posted by @rascani in https://github.com/pytorch/executorch/pull/18311#discussion_r2975773576
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ATOL and RTOL handling discussed in the referenced pull request discussion, since no implementation files or tests are named here. Trace where the current tolerances are defined and applied; done means individual tests can override them while the defaults are reduced and existing tests that need looser values specify those overrides.
Written by the indexing model from the issue text.
Assessment
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100