Support message matching in death tests
Open
@rascani is already working on this.
Since Dec 16, 2025.
- Dominant language
- Python
- Stars
- 5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 581
Description
🚀 The feature, motivation and pitch
In #16162, we added a variety of null pointer asserts and a corresponding set of death tests to ensure they are caught. An earlier revision of the the PR included message matchers for those assertions, but these all failed on Windows. The reason why was not immediately clear, but the default matcher for string literals is regex-based and there is different gtest regex parsing on posix systems than Windows & Mac.
It would be preferable to bring back the message matching and investigate why Windows failed. Having message matching would allow us to ensure that the right assert is firing.
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.