pytorch / pytorch/executorch

Remove build-time workspace sharing option

Open
#13,189 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

module: xnnpack
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

Once runtime support for workspace sharing is merged (https://github.com/pytorch/executorch/pull/11748), we won't need the build time config. We can remove it to simplify the code and build.

cc @digantdesai @mcr229 @cbilgin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review PR #11748 first to identify the runtime workspace-sharing support and the build-time option it supersedes. Trace references to that option in the repository, remove the obsolete configuration and its dependent code, and verify that the affected build still succeeds.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.