pytorch / pytorch/executorch

Incorrect display of logs for ARM bulds on FVP

Open
#13,038 8 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

module: arm partner: arm
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

I'm not sure, but it seems that the ARM GNU compiler (arm-none-eabi-gcc) does not support the c99 input/output format by default. I encountered a problem when I got the following output in FVP after running examples/arm/run.sh --model_name=add2 --target=ethos-u85-2048 --delegate

I [executorch:arm_executor_runner.cpp:zu ()] main
I [executorch:arm_executor_runner.cpp:zu ()] runner_init
I [executorch:arm_executor_runner.cpp:zu ()] runner_init
I [executorch:arm_executor_runner.cpp:zu ()] runner_init
I [executorch:arm_executor_runner.cpp:zu ()] runner_init
I [executorch:arm_executor_runner.cpp:zu ()] runner_init
...

After simply replacing %zu -> %lu in all ET_LOG() in file executorch/examples/arm/executor_runner/arm_executor_runner.cpp, I managed to get the following logs:

I [executorch:arm_executor_runner.cpp:749 main()] PTE in 0x74000000 $ Size: 2208 bytes
I [executorch:arm_executor_runner.cpp:480 runner_init()] PTE Model data loaded. Size: 2208 bytes.
I [executorch:arm_executor_runner.cpp:493 runner_init()] Model buffer loaded, has 1 methods
I [executorch:arm_executor_runner.cpp:500 runner_init()] Running method forward
I [executorch:arm_executor_runner.cpp:511 runner_init()] Setup Method allocator pool. Size: 62914560 bytes.
I [executorch:arm_executor_runner.cpp:528 runner_init()] Setting up planned buffer 0, size 96.

...

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with executorch/examples/arm/executor_runner/arm_executor_runner.cpp and reproduce the output using examples/arm/run.sh --model_name=add2 --target=ethos-u85-2048 --delegate. Inspect the ET_LOG format specifiers involved in the FVP output and verify the corrected logs include function names and values without truncation or placeholder text.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.