pytorch / pytorch/executorch

Vulkan amax/amin fail to lower with index out of range

Open
#12,227 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backend tester module: vulkan
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

🐛 Describe the bug

Models containing amax or amin error out in partitioning when using Vulkan.

import torch
from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
from executorch.exir import to_edge_transform_and_lower, EdgeCompileConfig, to_edge
from executorch.extension.pybindings.portable_lib import _load_for_executorch_from_buffer
from typing import Callable, List, Optional, Tuple, Union

class AmaxModel(torch.nn.Module):
    def forward(self, x):
        return torch.amax(x)
        
model = AmaxModel()
inputs = (
    torch.randn(10, 10),
)
eager_outputs = model(*inputs)

ep = torch.export.export(model.eval(), inputs)
print(ep)
lowered = to_edge_transform_and_lower(
    ep,
    partitioner=[VulkanPartitioner()],
    compile_config=EdgeCompileConfig(_check_ir_validity=False)
).to_executorch()
print(lowered.exported_program())

et_model = _load_for_executorch_from_buffer(lowered.buffer)
et_outputs = et_model([*inputs])[0]

print(f"Inputs: {inputs}")
print(f"Eager: {eager_outputs}")
print(f"ET:    {et_outputs}")

Output:

Cell In[21], line 19
     17 ep = torch.export.export(model.eval(), inputs)
     18 print(ep)
---> 19 lowered = to_edge_transform_and_lower(
     20     ep,
     21     partitioner=[VulkanPartitioner()],
     22     compile_config=EdgeCompileConfig(_check_ir_validity=False)
     23 ).to_executorch()
     24 print(lowered.exported_program())
     26 et_model = _load_for_executorch_from_buffer(lowered.buffer)

...

File /data/users/gjcomer/fbsource/buck-out/v2/gen/fbcode/fdcb6705e87e1def/bento_kernels/cria/__bento_kernel_cria_binary__/bento_kernel_cria_binary#link-tree/executorch/backends/vulkan/op_registry.py:453, in register_reduce_op.<locals>.check_reduce_node(node)
    452 def check_reduce_node(node: torch.fx.Node) -> bool:
--> 453     dim_list = node.args[1]
    454     if isinstance(dim_list, list) and len(dim_list) != 1:
    455         return False
IndexError: tuple index out of range
Versions

Run on Meta internal master, Jul 3, fbcode/SwiftShader

cc @SS-JIA @manuelcandales @cbilgin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with the AmaxModel example, then inspect executorch/backends/vulkan/op_registry.py at register_reduce_op and check_reduce_node, especially the access to node.args[1]. Done means Vulkan partitioning handles amax and amin without an IndexError and the provided model can complete lowering.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
backend, machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.