Refactor cmake Selective Build Option ROOT_OPS
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 581
Description
🚀 The feature, motivation and pitch
ROOT_OPS is a bit of a misnomer for what this option actually represents. We see in test_selective_build.sh the ROOT_OPS option to the gen_selected_ops macro is intended to be used to pass a list of operators for selective build. This should probably be renamed to something like OPS_LIST or SELECT_OPS_FROM_LIST.
Some places in the code that would need this refactor:
There are likely other places that need changes, but these would be some good places to start.
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
cc @mergennachin @byjlw @iseeyuan @lucylq @helunwencser @tarun292 @kimishpatel @jackzhxng
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tools/cmake/Codegen.cmake, codegen/tools/gen_oplist.py, and examples/selective_build/CMakeLists.txt, then search for other ROOT_OPS references. Rename the option consistently to the agreed replacement and run test_selective_build.sh to verify selective builds still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, python
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100