pytorch / pytorch/executorch

[Android] Rename JNI cpp file

Open
#10,890 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue module: android triaged
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

🚀 The feature, motivation and pitch

Would love to have name mapping between jni and java
Rename
extension/android/jni/jni_layer.cpp -> jni_module.cpp
extension/android/jni/jni_layer_llama.cpp -> jni_llm_module.cpp

cc @cbilgin @phaiting Does it make sense?

Alternatives

No response

Additional context

No response

RFC (Optional)

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with extension/android/jni/jni_layer.cpp and extension/android/jni/jni_layer_llama.cpp, then search the repository for references to both filenames. Done means the files use the requested names, jni_module.cpp and jni_llm_module.cpp, and all references remain consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, cpp
Domain
mobile-dev
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.