Get rid of fixed number cmake --build -j in sh and docs
Open
Nobody has claimed this yet.
good first issue
module: build/install
triaged
- Dominant language
- Python
- Stars
- 5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 581
Description
📚 The doc issue
Right now we have a few places where the number of cmake --build -j is fixed.
https://github.com/search?q=repo%3Apytorch%2Fexecutorch+%22+-j%22&type=code
Ideally let's use
mac: $(sysctl -n hw.ncpu) - 1
linux: $(nproc) - 1
Update these docs and scripts.
Suggest a potential alternative/fix
No response
cc @larryliu0820 @jathu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the repository code search linked in the issue, looking for fixed numbers passed to cmake --build -j in documentation and shell scripts. Replace those fixed values with the stated macOS and Linux CPU-count commands, then review every search result to confirm the docs and scripts no longer use a fixed build parallelism value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, shell
- Domain
- build-system, documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100