[CMake] Duplicated sources in extension_llm_runner and llama_runner
Open
@kirklandsign is already working on this.
Since May 7, 2025.
module: build/install
triaged
- Dominant language
- Python
- Stars
- 5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 581
Description
🐛 Describe the bug
These sources appeared twice:
extension/llm/runner/text_decoder_runner.cpp
extension/llm/runner/text_prefiller.cpp
extension/llm/sampler/sampler.cpp
Should llama_runner use llm/runner deps?
Versions
main 1984c5ff09fe5ec78fb905f66d5e6c63afdb4469
cc @larryliu0820 @jathu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.