[CMake] Duplicated entries in executorch_srcs.cmake
Open
@larryliu0820 is already working on this.
Since May 5, 2025.
module: build/install
triaged
- Dominant language
- Python
- Stars
- 5k
- Forks
- 1.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 581
Description
🐛 Describe the bug
The following files appear multiple times (by different target) in the file:
backends/apple/mps/runtime/MPSBackend.mm
backends/apple/mps/runtime/MPSCompiler.mm
backends/apple/mps/runtime/MPSDelegateHeader.mm
backends/apple/mps/runtime/MPSDevice.mm
backends/apple/mps/runtime/MPSExecutor.mm
backends/apple/mps/runtime/MPSGraphBuilder.mm
backends/apple/mps/runtime/MPSStream.mm
backends/apple/mps/runtime/operations/ActivationOps.mm
backends/apple/mps/runtime/operations/BinaryOps.mm
backends/apple/mps/runtime/operations/ClampOps.mm
backends/apple/mps/runtime/operations/ConstantOps.mm
backends/apple/mps/runtime/operations/ConvolutionOps.mm
backends/apple/mps/runtime/operations/IndexingOps.mm
backends/apple/mps/runtime/operations/LinearAlgebra.mm
backends/apple/mps/runtime/operations/NormalizationOps.mm
backends/apple/mps/runtime/operations/OperationUtils.mm
backends/apple/mps/runtime/operations/PadOps.mm
backends/apple/mps/runtime/operations/PoolingOps.mm
backends/apple/mps/runtime/operations/QuantDequant.mm
backends/apple/mps/runtime/operations/RangeOps.mm
backends/apple/mps/runtime/operations/ReduceOps.mm
backends/apple/mps/runtime/operations/ShapeOps.mm
backends/apple/mps/runtime/operations/UnaryOps.mm
devtools/etdump/data_sinks/buffer_data_sink.cpp
devtools/etdump/emitter.cpp
devtools/etdump/etdump_flatcc.cpp
examples/portable/executor_runner/executor_runner.cpp
extension/data_loader/file_data_loader.cpp
extension/data_loader/mmap_data_loader.cpp
extension/evalue_util/print_evalue.cpp
extension/flat_tensor/flat_tensor_data_map.cpp
extension/flat_tensor/serialize/flat_tensor_header.cpp
extension/llm/runner/text_decoder_runner.cpp
extension/llm/runner/text_prefiller.cpp
extension/llm/sampler/sampler.cpp
extension/module/module.cpp
extension/runner_util/inputs_portable.cpp
extension/runner_util/inputs.cpp
extension/tensor/tensor_ptr_maker.cpp
extension/tensor/tensor_ptr.cpp
extension/threadpool/thread_parallel.cpp
extension/threadpool/threadpool_guard.cpp
extension/threadpool/threadpool.cpp
extension/training/module/training_module.cpp
extension/training/optimizer/sgd.cpp
kernels/optimized/cpu/op_add.cpp
kernels/optimized/cpu/op_bmm.cpp
kernels/optimized/cpu/op_div.cpp
kernels/optimized/cpu/op_elu.cpp
kernels/optimized/cpu/op_exp.cpp
kernels/optimized/cpu/op_fft_c2r.cpp
kernels/optimized/cpu/op_fft_r2c.cpp
kernels/optimized/cpu/op_gelu.cpp
kernels/optimized/cpu/op_le.cpp
kernels/optimized/cpu/op_linear.cpp
kernels/optimized/cpu/op_log_softmax.cpp
kernels/optimized/cpu/op_mm.cpp
kernels/optimized/cpu/op_mul.cpp
kernels/optimized/cpu/op_native_layer_norm.cpp
kernels/optimized/cpu/op_neg.cpp
kernels/optimized/cpu/op_sigmoid.cpp
kernels/optimized/cpu/op_sub.cpp
kernels/optimized/cpu/op_where.cpp
kernels/portable/cpu/util/reduce_util.cpp
kernels/prim_ops/et_copy_index.cpp
kernels/prim_ops/et_view.cpp
kernels/prim_ops/register_prim_ops.cpp
runtime/core/evalue.cpp
runtime/core/exec_aten/util/tensor_shape_to_c_string.cpp
runtime/core/portable_type/tensor_impl.cpp
runtime/core/tag.cpp
runtime/executor/test/test_backend_compiler_lib.cpp
runtime/platform/abort.cpp
runtime/platform/default/posix.cpp
runtime/platform/log.cpp
runtime/platform/profiler.cpp
runtime/platform/runtime.cpp
We should review to see if that's really needed. Otherwise, very likely we are missing deps.
Versions
main 306430825c2ffe2061221a197904e2f79e628998
cc @larryliu0820 @jathu
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.