pytorch / pytorch/executorch

[CMake] When should we use static lib and when shared

Open
#10,461 1 comment 1 reaction 3 assignees View on GitHub

@larryliu0820 is already working on this.

Since Apr 25, 2025.

module: build/install triaged
Dominant language
Python
Stars
5k
Forks
1.2k
Avg merge
2d 10h
Merged PRs (30d)
581

Description

🐛 Describe the bug

We can definitely split backends and ops into its own .so library.

Right now we don't have a clear guideline when to use which.

We also have something like

 if(CMAKE_TOOLCHAIN_IOS
    OR CMAKE_TOOLCHAIN_ANDROID
    OR APPLE
 )

repeating.

Versions

main
a325c56864c5b25630c1ebda03c8f16a96a02a19

cc @larryliu0820 @jathu

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.