pytorch / pytorch/cpuinfo

Why do we need 'get_system_info_from_registry' for ARM64 device?

Open
#245 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
1.2k
Forks
409
PR merge metrics
No merged PRs in 30d

Description

Why do we need to read the register key 'HARDWARE\DESCRIPTION\System\CentralProcessor\0' and compare it with the data in the array 'woa_chips'?
Only Windows On ARM devices have this code. This is not friendly to the compatibility of new Windows On ARM devices.

https://github.com/pytorch/cpuinfo/blob/3c8b1533ac03dd6531ab6e7b9245d488f13a82a5/src/arm/windows/init.c#L154

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/arm/windows/init.c around line 154 and trace get_system_info_from_registry, the HARDWARE\DESCRIPTION\System\CentralProcessor\0 registry key, and the woa_chips array. Determine why the registry value is compared and how that affects newer Windows On ARM devices. Done means documenting the rationale and defining a compatible change, with any relevant validation identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.