pytorch / pytorch/benchmark

Missing `test_bench` configuration support

Open
#2,590 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1k
Forks
346
PR merge metrics
No merged PRs in 30d

Description

Seems --config is defined but not used actually in the test_bench userbenchmark. I would like to add support for it if this change makes sense.

https://github.com/pytorch/benchmark/blob/43851fb1208fad5708af8488789754b90fe94ec6/userbenchmark/test_bench/run.py#L307-L309

cc: @xuzhao9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in userbenchmark/test_bench/run.py at the referenced lines where --config is defined, then trace how test_bench arguments are consumed. Determine the expected configuration behavior from the surrounding entry point and existing benchmark conventions; done means --config is no longer ignored and the relevant benchmark path uses it consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
performance
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.