float sample_rate
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 799
- Avg merge
- 58m
- Merged PRs (30d)
- 3
Description
torchaudio currently treats sample_rate as an integer. In #890, it was mentioned that float may be more appropriate.
- Librairies we use for saving/loading may not support float sample_rate.
- C++ extensions currently use int.
- torchaudio signatures use int.
Thoughts?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading this discussion and the referenced issue #890; no files, tests, or entry points are named. Determine whether float sample_rate is supported by the saving/loading libraries, C++ extensions, and torchaudio signatures, then document a decided direction and its scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python, pytorch
- Domain
- audio-video-rtc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100