pytorch / pytorch/audio

Support custom padding in istft

Open
#500 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
799
Avg merge
58m
Merged PRs (30d)
3

Description

🚀 Feature

Current version of istft force check NOLA thus some kind of padding (e.g. asymmetrical padding or #427 ) will raise assertion error. I would like to see there is a way to support custom padding. maybe just give a choice to manually disable NOLA check.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the istft entry point and trace where the NOLA assertion rejects custom padding; review the related padding discussion in issue #427. Done means asymmetrical or other custom padding can be used without the current assertion failure, while the existing validation behavior remains available or unchanged by default.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
audio-video-rtc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.