The ffmpeg integration shouldn't download linux binaries when the UNIX cmake variable is defined - it should issue proper messages for non-Linux UNIX systems
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 799
- Avg merge
- 58m
- Merged PRs (30d)
- 3
Description
🐛 Describe the bug
The cmake code assumes here that UNIX implies linux, which isn't correct.
The code should check whether OS is Linux and only download linux binaries in that case.
It should issue the relevant error message for other OSes.
*BSD systems are in the UNIX category but aren't able to run linux binaries.
Versions
2.x.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at third_party/ffmpeg/multi/CMakeLists.txt around line 59 and inspect how the UNIX condition controls binary downloads. Confirm the CMake logic distinguishes Linux from other UNIX systems and emits the relevant error message instead of downloading Linux binaries for unsupported systems.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100