pytoolz / pytoolz/toolz

assoc with multiple keys

Open
#402 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5.2k
Forks
280
Avg merge
6d 17h
Merged PRs (30d)
4

Description

I'm wondering if there's a reason that assoc only takes one k,v pair? Considering that the function does copy on write, it seems like it would be efficient to do:

assoc(mydict, k1, v1, k2, v2..., factory=dict)

I suppose that this would be a breaking change for people not using the keyword in the factory arg.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the assoc entry point and its tests, then review how the factory keyword is currently handled and whether positional arguments are covered. Done means establishing a compatible way to accept multiple key/value pairs without breaking existing factory usage, with tests for the proposed calling forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.