python / python/typing-council

Spec Change : Additional detail and option for platform checks.

Open
#52 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
57
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Hello Typing council,

Please consider the proposal in the PR and Discussion below.

The Discussion has overal positive feedback, but did not receive concrete feedback on the refinement and implementation questions posed, so Ill repeat them here so the PR can be adjusted as needed based on the feedback.

Open Questions:

Scope of sys.platform collections:

  • Should typecheckers support any iterable, or limit to tuple or set literals?
    Recommend: Only tuple literals; Optionally set literals if feasible for type checkers

  • Should typecheckers support not in checks?
    Recommend: Yes

sys.implementation attributes:

  • Should typecheckers support sys.implementation.version comparisons (similar to sys.version_info)?
    No preference.

Combining version, platform, and implementation checks:

  • Should typecheckers explicitly allow combined checks , (e.g., if sys.platform == "linux" and sys.implementation.name == "pypy":)?
    Recommend: Yes, as long as each individual check is supported. This is not explicitly specified in the proposed text, as the implementation complexity for type checkers needs further assessment.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked spec proposal PR #2173, then read the Discussion and earlier Q&A for context. Review the open questions about iterable forms, not-in checks, implementation version comparisons, and combined checks; the work is done when the proposal reflects resolved decisions and the PR is updated accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.