Don't run pyright basic checks on projects with strict pyright settings in CI
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.1k
- Forks
- 2.1k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 82
Description
Relevant CI configuration: https://github.com/python/typeshed/blob/67895308f89221c97c67c13845b96d65d725750c/.github/workflows/tests.yml#L126-L140
This could lead to a deadlock situation with Schrodinger's pyright: ignore comments that are only relevant to the strict run but throw error: Unnecessary "# pyright: ignore" in the basic checks run. See recent CI runs in #16004 for an example.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/tests.yml at lines 126-140 and review the recent CI runs referenced in issue #16004. Trace how projects with strict pyright settings are selected for basic checks. Done means strict projects no longer produce unnecessary pyright-ignore errors during the basic run while the intended CI checks remain covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, python
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100