python / python/pythondotorg

A way to "merge" sponsor objects in python.org/admin

Open
#2,370 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

admin app/sponsors backend enhancement
Dominant language
Python
Stars
1.7k
Forks
700
Avg merge
2d 13h
Merged PRs (30d)
11

Description

Is your feature request related to a problem? Please describe.
Sometimes when submitting an application on our sponsor application page , sponsors will unintentionally create a second sponsor object for the same company.

This creates problems with populating renewal dates among other things--If the contract is a renewal, but it is not connected to the sponsor object associated with the last contract, the date of last contract is "UNKNOWN" and when I try to download the renewal contract I get a 500 error.

Describe the solution you'd like
It would be nice to have a way in https://www.python.org/admin/sponsors/sponsor/ to merge duplicate sponsor objects. Ideally they would retain the information/files from the most recently created sponsor object and/or ask which to retain.

Describe alternatives you've considered
Currently I haven't been able to find a way to generate a renewal contract in the case of duplicate sponsor objects, so I've just been manually creating the contract from the template in those cases. (E.g. frequently the sponsor contacts change from year to year, and sometimes the logo gets updated or other details change.)

Additional context

Screenshot 2024-02-16 at 17-11-13 Select sponsor to change python org

@ewdurbin

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the sponsor administration page and the sponsor application flow, then trace how sponsor objects, contacts, logos, files, and renewal contracts are related. Define how duplicate records should be merged or which information should be retained, and verify that renewal contracts no longer fail with a 500 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.