50% of regex_v8 benchmark time is 2 regexes
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 203
- Avg merge
- 1h 20m
- Merged PRs (30d)
- 2
Description
These 2 lines in block1:
regexs[17].sub(r'', strings[2], count=subcount[17])
# This prints a unicode escape where the V8 version prints the
# unicode character.
regexs[17].sub(r'', strings[3], count=subcount[17])
take 140 ms to run
while full benchmark takes 300 ms.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the regex_v8 benchmark and its block1 section, focusing on the two regexs[17].sub calls shown in the issue. Profile or time those calls and compare the result with the full benchmark and V8 behavior. Done means the benchmark remains correct and those calls no longer account for roughly half of its runtime.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100