python / python/pyperformance

Benchmark Groups Have Some Minor Problems

Open
#234 3 comments 0 reactions 1 assignee View on GitHub

@ericsnowcurrently is already working on this.

Since Aug 19, 2022.

Dominant language
Python
Stars
1k
Forks
203
Avg merge
1h 20m
Merged PRs (30d)
2

Description

(See https://github.com/pyston/python-macrobenchmarks/pull/10.)

  • a benchmark group "all" is allowed, but ignored
  • duplicate groups are allowed (between manifest files) but the semantics aren't clear
  • a group will overwrite a tag with the same name, without warning
  • the "list_groups" command does not show tags if any custom groups are defined
  • tags aren't found properly in BenchmarksManifest.resolve_group()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.