Support adding class variables to class through assignment
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
Mypy supports adding items to self during test setUp, which is great. However in many cases it's useful to be able to add items to the class during setUpClass (or Django's setUpTestData).
import unittest
class Tests(unittest.TestCase):
@classmethod
def setUpClass(cls) -> None:
cls.foo = 42 # "Type[Tests]" has no attribute "foo"
def test_foo(self) -> None:
print(self.foo) # "Tests" has no attribute "foo"
Adding a ClassVar allows for a workaround to this, however it would be nice if that wasn't needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how mypy handles assignments to self in setUp and class-variable declarations, then inspect tests covering ClassVar and unittest setup hooks. Define expected diagnostics for cls.foo and self.foo in setUpClass or setUpTestData, and add focused regression tests showing that the supported assignments no longer produce attribute errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100