__set_name__ isn't checked
Open
Nobody has claimed this yet.
feature
priority-1-normal
topic-descriptors
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
from typing import Type
class Foo:
def __set_name__(self, owner: Type['Bar'], name: str) -> None:
...
class Bar:
foo_bar = Foo() # correctly passes
class Baz:
foo_baz = Foo() # should fail
mypy correctly accepts Bar.foo_var, but incorrectly accepts Baz.foo_baz
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the supplied example with mypy and inspect how descriptor set_name annotations are checked. The fix is done when Bar.foo_bar remains accepted while Baz.foo_baz is rejected, with coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100