python / python/mypy

Add support for classmethod converters in attrs plugin

Open
#7,912 4 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature priority-1-normal topic-attrs
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

import attr

@attr.s
class Bar:
    b = attr.ib()

    @classmethod
    def make(cls, one: int) -> 'Bar':
        return cls(one)


@attr.s
class Foo:
    a = attr.ib(converter=Bar.make)

error: Unsupported converter, only named functions and types are currently supported

Attrs is perfectly happy with make

>>> Foo(1)
Foo(a=Bar(b=1))

Granted the converter limitations are a known issue, I couldn't find this use-case covered anywhere.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported error with the classmethod converter example in the issue, then trace the attrs plugin's converter handling. Done means classmethod converters such as Bar.make are accepted without the unsupported-converter error and the example remains correctly type-checked.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.