python / python/mypy

Prefer `__new__` over `__init__` for determining callable type of a class

Open
#5,647 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

#5642 made __new__ chosen in more situations but __init__ is still chosen when
one class defines both. The difficulty is that typeshed has a bunch of dodgy __new__
annotations that need to be cleaned up first.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #5642 and the callable-type handling for classes that define both new and init. Then inspect the affected typeshed annotations and identify the dubious new cases that must be corrected first. Done means valid annotations are cleaned up and class callable types consistently prefer new.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers, devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.