Fine-grained reacts poorly to missing core cache files

Open
#4,909 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Reproduce the failure with the builtins cache unavailable, then trace the cache-loading path and the handling of missing typing data. Run the existing test suite to identify the additional errors mentioned in the issue; done means missing critical cache files no longer cause crashes and the affected tests pass.

Written by the indexing model from the issue text.

Description

crash topic-fine-grained-incremental

If the cache for builtins can't be loaded, fine-grained will basically always crash trying to create builtins.objects. There are some crashes if it can't loading typing also, maybe other things.

The solution is probably to fall back to not using a cache if the most critical cache files are missing, but I get a handful of test failures where we produce additional errors when I do that, so it will require a bit more work.

https://github.com/python/mypy/issues/4909#tasklist-block-93702cbf-70c7-4625-a29a-d4dc673c1426

Dominant language
Python
Stars
20.6k
Forks
3.3k
Avg merge
1d 18h
Merged PRs (30d)
54

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/mypy

All issues in python/mypy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.