Fine-grained: Make sure all nodes in symbol tables have fullnames if needed

Open

#4,724 opened on Mar 13, 2018 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 4/5
Estimated time: 3-5 days
Newbie friendliness: 25/100

Issue type: Bug
Clarity: Needs clarification
Activity status: Stale
Tech stack: python
Domain: compilers

Research direction

Start by tracing how Node objects enter symbol tables and where full names are assigned or left as None. Inspect the refresh comparison and AST diff paths; done means symbol-table nodes have reliable full names where needed without breaking alias checks or unrefreshable variables.

Written by the indexing model from the issue text.

Description

priority-0-high topic-fine-grained-incremental

If a Node object stored in a symbol table doesn't have a full name defined (i.e. it's None) we can't refresh that node reliably since we have to check that the symbol table node doesn't hold a alias to something else, and we do this comparison using the full name.

If the node can't be refreshed (e.g. variables), a missing full name might still be a problem for AST diff, for example.

Dominant language: Python
Stars: 20.6k
Forks: 3.3k
Avg merge: 1d 18h
Merged PRs (30d): 54

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.