fine-grained checking with cache misses deleted module imported with import from

Open
#4,698 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
compilers

Research direction

Start with the testDeletionOfSubmoduleTriggersImportFrom1-skip-nocache test and its cache/no-cache fixture, including the p/q.py deletion and recreation steps. Reproduce the case without the harness reporting p/q.py as changed, then investigate how the daemon tracks this imported submodule. Done means the daemon detects the change and reports the expected missing-module error.

Written by the indexing model from the issue text.

Description

bug priority-1-normal topic-fine-grained-incremental

The testDeletionOfSubmoduleTriggersImportFrom1-skip-nocache test only passes because the current testfinegrained harness reports p/q.py as changed. The actual daemon fails to detect the change, however, as it never knows to care about p/q.py in the first place.

[case testDeletionOfSubmoduleTriggersImportFrom1-skip-nocache]
-- Different cache/no-cache tests because:
-- missing module error message mismatch
from p import q
[file p/__init__.py]
[file p/q.py]
[delete p/q.py.2]
[file p/q.py.3]
[out]
==
main:1: error: Cannot find module named 'p.q'
main:1: note: (Perhaps setting MYPYPATH or using the "--ignore-missing-imports" flag would help)
==
Dominant language
Python
Stars
20.6k
Forks
3.3k
Avg merge
1d 18h
Merged PRs (30d)
54

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/mypy

All issues in python/mypy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.