Mypy doesn't understand __class__

Open
#4,177 8 comments 22 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
devtools

Research direction

Reproduce the report using the Python example in x.py and run mypy to confirm the undefined class error. Trace the type checker's name resolution for class, then add a regression test showing that it is understood as Foo and verify the test suite passes.

Written by the indexing model from the issue text.

Description

feature priority-2-low

Consider the following (Python 3, of course)

from typing import Any

class Foo:
    def foo(self, x:Any) -> bool:
        return isinstance(x, __class__)

mypy gives the following error:

x.py:5: error: Name '__class__' is not defined

It should assume __class__ to be Foo (as per the language documentation).

I usually work around this by adding

if TYPE_CHECKING:
    __class__ : Type

at the top of files that use __class__, but that's not ideal.

Dominant language
Python
Stars
20.6k
Forks
3.3k
Avg merge
1d 18h
Merged PRs (30d)
54

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/mypy

All issues in python/mypy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.