python / python/mypy

redefinition-new does not apply type narrowing on cast-like function calls

Open
#21,532 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

Bug Report

I have a function to which I am passing both a type and a value that the function converts to be of that type.

(In the example, the function simply calls cast, in my actual use case it does some actual conversions of course.)

mypy correctly determines the type of the return, but assigning this return to the variable does not narrow the type of the variable, when using --allow-redefinition-new. This does not happen with --allow-redefinition-old

For other function calls that convert the input, this works perfectly fine.

(A clear and concise description of what the bug is.)

To Reproduce

from collections.abc import Collection
from typing import Any, cast, reveal_type

def convert[T](type_: type[T], x: Any) -> T:
    return cast(T, x)

def to_set[T](x: Collection[T]) -> set[T]:
    return set(x)

def foo(x: Collection[int]) -> None:
    reveal_type(x)  # Collection[int]
    reveal_type(convert(set[int], x))  # set[int]
    x = convert(set[int], x)
    reveal_type(x)  # old: set[int], new: Collection[int]

def bar(x: Collection[int]) -> None:
    reveal_type(x)  # Collection[int]
    reveal_type(cast(set[int], x))  # set[int]
    x = cast(set[int], x)
    reveal_type(x)  # set[int]

def baz(x: Collection[int]) -> None:
    reveal_type(x)  # Collection[int]
    reveal_type(set(x))  # set[int]
    x = set(x)
    reveal_type(x)  # set[int]

def brr(x: Collection[int]) -> None:
    reveal_type(x)  # Collection[int]
    reveal_type(to_set(x))  # set[int]
    x = to_set(x)
    reveal_type(x)  # set[int]

Playground 1.20.2 old redefinitions

Playground 1.20.2 new redefinitions

Playground 2.1.0 new redefinitions

(The playground does not support --allow-redefinition-old so you cannot use the old variant with 2.0+)

Expected Behavior

After x = convert(set[int], x) the type of x should be narrowed to set[int].

Actual Behavior

It works with the old, but not the new --allow-redefinition.

Your Environment

I encountered this when upgrading to mypy==2.0.0, when the default behavior of --allow-redefinition changed from old to new, but this also happens on mypy==1.20.2 and mypy==2.1.0.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the provided reproducer with --allow-redefinition-new and compare its revealed types with the old behavior. Trace how assignments from convert(), cast(), and set() are handled in the new redefinition analysis, then add a regression test showing that x becomes set[int] after the assignment.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.