python / python/mypy

[Regression 1.19.1 -> 1.20.0] `value in container` based narrowing causes false negatives.

Open
#21,512 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

mypy seems to narrow the type of value in a if value in container branch, which leads to false negatives.

class Size(tuple[int, ...]):
    def numel(self) -> int:
        return 0  # math.prod(self)

sizes: list[Size] = [Size([1, 2, 3])]
print(sizes[0].numel())  # OK
value = (1, 2, 3)
if value in sizes:
    reveal_type(value)  # mypy: Size; pyright, ty, zuban, pyrefly: tuple
    print(value.numel())  # ERROR at runtime

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the narrowing difference in the linked mypy-play examples with versions 1.19.1 and 1.20.0, then trace the handling of value in sizes and its revealed type. Add a regression test for the Size and tuple example, and confirm that mypy retains the tuple type and reports the invalid numel() call.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.