python / python/mypy

Drop pathspec dependency?

Open
#21,298 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature needs discussion
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

It looks like pathspec has had two non-backward compatible changes in a fairly small time window which broke CI in master. Since it doesn't seem to provide any super critical functionality, maybe it's less trouble to switch to a custom replacement? Maybe this would even be meaningfully faster in some respects (e.g. import time).

Thoughts?

cc @ilevkivskyi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing how the pathspec dependency is used and the master CI failures caused by its non-backward-compatible changes. Define the required behavior for a custom replacement, remove the dependency without regressions, and verify that CI passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.