python / python/mypy

Inconsistent feeling handling of Any in binder

Open
#20,870 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug topic-type-narrowing
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

from typing import Any, Final

CONSTANT: Final = 2015

def good(result: dict[str, Any]) -> None:
    code = 'asdf'
    if isinstance(result, dict):
        code = result.get('code', code)
    reveal_type(code)  # N: Revealed type is "Any"
    if code == CONSTANT:
        reveal_type(code)  # N: Revealed type is "Any"

def bad(result: Any) -> None:
    code = 'asdf'
    if isinstance(result, dict):
        code = result.get('code', code)
    reveal_type(code)  # N: Revealed type is "builtins.str"
    if code == CONSTANT:
        reveal_type(code)  # N: Revealed type is "builtins.str"

Based on real world code for rotki

This feels a little inconsistent / violating of gradual typing
Not exactly sure what if anything we should do, though

Found this via https://github.com/python/mypy/pull/20660 which makes --warn-unreachable flag raise a diagnostic on the second comparison

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two examples and inspect the binder or type-narrowing path they exercise; the issue names no source file or test. Before changing behavior, establish the intended gradual-typing semantics with maintainers, then add a regression test for the agreed result.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.