TypeForm: Recognize type variables in a consistent way
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
Prerequisite: This issue applies after PR https://github.com/python/mypy/pull/19596 is merged.
Currently mypy sometimes allows a type variable to be assigned to a TypeForm variable and sometimes it does not. This is a problem because the behavior is inconsistent.
Specifically, mypy allows a type variable to be assigned to a TypeForm variable iff it is in a quoted type expression:
[case testTypeVarTypeFormsAreOnlyRecognizedInStringAnnotation]
...
E = TypeVar('E')
class Box(Generic[E]):
def foo(self, e: E) -> None:
list_of_typx: List[TypeForm] = [E] # E: "E" is a type variable and only valid in type context
typx1: TypeForm = E # E: "E" is a type variable and only valid in type context
typx2: TypeForm = 'E'
When a type variable is NOT quoted, mypy will not allow it to be assigned:
[case testEveryKindOfTypeExpressionIsAssignableToATypeFormVariable]
SomeTypeVar = TypeVar('SomeTypeVar')
typx: TypeForm
...
# NOTE: Unbound TypeVar isn't currently accepted as a TypeForm. Is that OK?
typx = SomeTypeVar # E: Incompatible types in assignment (expression has type "TypeVar", variable has type "TypeForm[Any]")
I'd argue that TypeForm should always accept a type variable because it is a valid type expression and TypeForms are intended to accept all kinds of type expressions:
def cast[T](type_expr: TypeForm[T], value_expr: object) -> T: ...
cast(SomeTypeVar, some_expression) # should not be an error
In summary:
- mypy should allow a type variable to be assigned to a TypeForm variable, regardless of whether it is quoted or not. Update above-referenced tests to reflect this new behavior.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First review prerequisite PR #19596, then locate the tests named testTypeVarTypeFormsAreOnlyRecognizedInStringAnnotation and testEveryKindOfTypeExpressionIsAssignableToATypeFormVariable. Check how quoted and unquoted type variables are handled for TypeForm assignments. Done means both cases consistently allow type variables and the tests reflect the new behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100