When using `isinstance` to infer a generic type in a block, use any covariant bounds on the type variable.

Open
#1,998 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
compilers, devtools

Research direction

Start with the isinstance-based generic inference example in the issue and reproduce its reveal_type result for AppleAction. Done means covariant, bounded type variables are reflected in the inferred type rather than producing AppleAction[Any], with the behavior validated for the shown hierarchy.

Written by the indexing model from the issue text.

Description

bug priority-1-normal topic-type-variables

I have a class hierarchy like the following:

class Apple(object): ...

T_co = TypeVar('T_co', covariant=True)
A_co = TypeVar('A_co', bound=Apple, covariant=True)

class Action(Generic[T_co]): ...

class AppleAction(Generic[A_co], Action[A_co]): ...

Later in my code, I have a block like so:

if isinstance(action, AppleAction):
   reveal_type(action)

And I get AppleAction[Any]. Because A_co is covariant, and bounded by Apple, even if A_co is bound to a subtype of Apple, the resulting object is going to be a valid instance of AppleAction[Apple]. I'd like to have action be AppleAction[Apple] in this case.

Dominant language
Python
Stars
20.6k
Forks
3.3k
Avg merge
1d 18h
Merged PRs (30d)
54

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from python/mypy

All issues in python/mypy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.