dmypy suggest generates syntax error in annotation in some cases
Open
Nobody has claimed this yet.
bug
topic-daemon
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
Bug Report
sometimes dmypy puts a : for some annotations instead of a . and is inconsistent with some types from typing
To Reproduce
class C: pass
def f1():
return [C()]
def f2():
return [1]
def f3():
return (C(),)
def f4():
return (1,)
[mypy]
check_untyped_defs = true
Expected Behavior
$ dmypy run .
...
$ dmypy suggest t.f1
() -> List[t.C]
$ dmypy suggest t.f2
() -> List[int]
$ dmypy suggest t.f3
() -> Tuple[t.C]
$ dmypy suggest t.f4
() -> Tuple[int]
Actual Behavior
$ dmypy run .
...
$ dmypy suggest t.f1
() -> typing:List[t.C]
$ dmypy suggest t.f2
() -> typing.List[int]
$ dmypy suggest t.f3
() -> Tuple[t.C]
$ dmypy suggest t.f4
() -> Tuple[int]
two separate oddities here:
- the first produces
typing:List(with a colon) instead oftyping.List(the colon appears to come from here -- https://github.com/python/mypy/blob/454989f7c085d5a7f86ad7ed9da0f2614ca41d83/mypy/suggestions.py#L853 )- I guess the colon is supposed to help with differentiating
mod.Class.NestedClassvsmod.submod.Class? though it seems to make no sense forListhere
- I guess the colon is supposed to help with differentiating
typing.ListandTupleshould either both be fully qualified or neither
Your Environment
- Mypy version used: 1.15.0
- Mypy command-line flags: see above
- Mypy configuration options from
mypy.ini(and other config files): see above - Python version used: 3.13.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the shown dmypy suggest examples, then inspect mypy/suggestions.py around line 853 to trace how annotation names are formatted. Done means the List and Tuple outputs use consistent qualification and no annotation contains the erroneous colon; verify against all four examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100