Partial type that is "initialised" via assignment is only temporarily narrowed by `isinstance`
Open
Nobody has claimed this yet.
bug
topic-type-narrowing
- Dominant language
- Python
- Stars
- 20.6k
- Forks
- 3.3k
- PR merge metrics
- PR metrics pending
Description
In the following example, the last revealed type could/should be Union[builtins.int, None]:
def f() -> bool:
return True
u: int | tuple[int]
x = None
if f():
x = u
if isinstance(x, tuple):
x = x[0]
reveal_type(x) # note: "builtins.int"
reveal_type(x) # note: Revealed type is "Union[builtins.int, Tuple[builtins.int], None]"
See this comment for background information.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue's Python example and compare the two reveal_type results with the expected narrowing. Read the linked comment on PR #18180 for background, then trace the type-checking path responsible for assignment-based narrowing. Done means the final revealed type is int | None without regressing the demonstrated behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100