python / python/mypy

Conditional statements don't work inside a NamedTuple class body

Open
#18,187 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug topic-named-tuple
Dominant language
Python
Stars
20.6k
Forks
3.3k
PR merge metrics
PR metrics pending

Description

Bug Report

Mypy generates an error when conditional statements are used inside the class body of a NamedTuple. This is mostly a problem in typeshed.

To Reproduce

from typing import NamedTuple
import sys

class Foo(NamedTuple):
    bar: str
    if sys.version_info >= (3, 10):
        def extra(self) -> str:
            return ""
    else:
        def other(self) -> str:
            return ""

Mypy Playground

Expected Behavior

Mypy generates no error.

Actual Behavior

main.py:6: error: Invalid statement in NamedTuple definition; expected "field_name: field_type [= default]"  [misc]
Found 1 error in 1 file (checked 1 source file)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the NamedTuple class-body handling and reproduce the issue using the Python snippet in this report. Run mypy against the conditional-method example; done means the valid version-dependent methods produce no Invalid statement in NamedTuple definition error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.